fix(opencode): handle unsupported import formats#23970
Open
LufyCZ wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): handle unsupported import formats#23970LufyCZ wants to merge 1 commit intoanomalyco:devfrom
LufyCZ wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
6 tasks
LufyCZ
force-pushed
the
import-format-message
branch
from
4d432ac to
b024222
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23957
Type of change
What does this PR do?
Opencode currently returns a misleading "File not found" message when importing unsupported file formats. This PR adds an early check for if a file exists and fails with
File not foundif it doesn't, or withUnsupported format: ${args.file} is not a valid JSON session fileif it does but does not have a supported format.How did you verify your code works?
A quick
bun dev import foo.mdrun.Checklist